Social Link: Rename mail to email #25924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaz
added
the
[Block] Social
|
Size Change: +10 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
mkaz
force-pushed
the
fix/21733-social-email
branch
from
6064232 to
da21ffe
Compare
ntsekouras
reviewed
Oct 8, 2020
There was a problem hiding this comment.
Hey @mkaz - thanks for this PR!
While the wanted result is achieved with this change, I think the proper solution would be to add keywords to the variation. You could also then add more than one and without the need to match the title.
Example:
keywords: [ 'email', 'another keword' ]
|
@ntsekouras Thanks for the review, and suggestion. It is weird, I attempted that the first time and also trying the Pushed up the switch now and tested and works fine. 👍 |
ntsekouras
approved these changes
Oct 8, 2020
This makes the mail icon show if the user searches for mail or email. The property value does not change, it stays as 'mail' so is still compatibility with any existing social links. The title change only allows it show up in search for both. Fixes #21733
mkaz
force-pushed
the
fix/21733-social-email
branch
from
d4d2ba4 to
979d041
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes the mail icon show if the user searches for mail or email.
The property value does not change, it stays as 'mail' so is still
compatibility with any existing social links.
The title change only allows it show up in search for both.
Fixes #21733
How has this been tested?
Feature check:
Compatibility check:
Types of changes